Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add outline-fade less variable #20227

Merged
merged 2 commits into from Mar 5, 2020
Merged

Conversation

Satloff
Copy link
Contributor

@Satloff Satloff commented Dec 12, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃挕 Background and solution

Some users may want to change the opacity of the face surrounding forms when active. Adding a variable called outline-fade to acomodate that.

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English adds @outdline-fade variable to default.less
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@Satloff Satloff changed the title add outline-fade less variable feat: add outline-fade less variable Dec 12, 2019
@netlify
Copy link

@netlify netlify bot commented Dec 12, 2019

Deploy preview for ant-design ready!

Built with commit dd30de9

https://deploy-preview-20227--ant-design.netlify.com

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Dec 12, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5363d70:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Dec 12, 2019

Codecov Report

No coverage uploaded for pull request base (master@164a4ac). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #20227   +/-   ##
=========================================
  Coverage          ?   97.81%           
=========================================
  Files             ?      286           
  Lines             ?     7735           
  Branches          ?     2164           
=========================================
  Hits              ?     7566           
  Misses            ?      169           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 164a4ac...5363d70. Read the comment docs.

@Satloff Satloff changed the title feat: add outline-fade less variable add outline-fade less variable Dec 13, 2019
@yoyo837 yoyo837 changed the title add outline-fade less variable feat: add outline-fade less variable Dec 13, 2019
@Satloff
Copy link
Contributor Author

@Satloff Satloff commented Dec 15, 2019

@afc163 can you review this?

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 26, 2019

Hi @Satloff, master only accept bug fix since v3 is in maintaining. Could you help change this PR base from master to 4.0-prepare branch?

Thanks

@afc163 afc163 removed the enhancement label Jan 8, 2020
@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Jan 9, 2020

master merged 4.0 a few days ago.

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 5, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants