Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modal combine Drawer cause overflow invalid #20242

Merged
merged 3 commits into from Dec 13, 2019

Conversation

@shaodahong
Copy link
Collaborator

shaodahong commented Dec 13, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Fixes #19956
Fixes #20175

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English 修复 Modal 和 Drawer 结合使用导致滚动失效
🇨🇳 Chinese fix Modal combine Drawer cause overflow invalid

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@auto-add-label auto-add-label bot added the bug label Dec 13, 2019
@pr-triage pr-triage bot added the PR: unreviewed label Dec 13, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Dec 13, 2019

Deploy preview for ant-design ready!

Built with commit f192cae

https://deploy-preview-20242--ant-design.netlify.com

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Dec 13, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f192cae:

Sandbox Source
antd reproduction template Configuration
sharp-banzai-e8vvn Issue #19956
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #20242 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20242   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files         286      286           
  Lines        7735     7735           
  Branches     2178     2164   -14     
=======================================
  Hits         7566     7566           
  Misses        169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a90e447...f192cae. Read the comment docs.

package.json Outdated Show resolved Hide resolved
@afc163 afc163 merged commit 65ea688 into ant-design:master Dec 13, 2019
11 of 18 checks passed
11 of 18 checks passed
ci/circleci: check_metadata Your tests are queued behind your running builds
Details
ci/circleci: compile CircleCI is running your tests
Details
ci/circleci: dist CircleCI is running your tests
Details
ci/circleci: test_dom CircleCI is running your tests
Details
ci/circleci: test_dom_15 CircleCI is running your tests
Details
ci/codesandbox Building packages...
Details
netlify/ant-design/deploy-preview Deploy preview processing.
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
security/snyk - package.json (paranoidjk) No new issues
Details
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Dec 13, 2019
@shaodahong shaodahong deleted the shaodahong:fix-modal-switch-effect branch Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.