Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Input element for Skeleton #20264

Merged
merged 5 commits into from Dec 19, 2019
Merged

feat: add Input element for Skeleton #20264

merged 5 commits into from Dec 19, 2019

Conversation

hi-rustin
Copy link
Contributor

@hi-rustin hi-rustin commented Dec 15, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#18237

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English feat: add Input element for Skeleton
🇨🇳 Chinese feat: 添加骨架输入框

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/skeleton/demo/element.md
View rendered components/skeleton/index.en-US.md
View rendered components/skeleton/index.zh-CN.md

@netlify
Copy link

@netlify netlify bot commented Dec 15, 2019

Deploy preview for ant-design ready!

Built with commit e337eed

https://deploy-preview-20264--ant-design.netlify.com

@hi-rustin hi-rustin changed the title Rustin patch skeleton input feat: add Input element for Skeleton Dec 15, 2019
@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Dec 15, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e337eed:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Dec 15, 2019

Codecov Report

Merging #20264 into 4.0-prepare will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           4.0-prepare   #20264      +/-   ##
===============================================
+ Coverage        97.55%   97.56%   +<.01%     
===============================================
  Files              294      295       +1     
  Lines             6839     6849      +10     
  Branches          1870     1878       +8     
===============================================
+ Hits              6672     6682      +10     
  Misses             167      167
Impacted Files Coverage Δ
components/skeleton/Skeleton.tsx 100% <ø> (ø) ⬆️
components/skeleton/index.tsx 100% <100%> (ø) ⬆️
components/skeleton/Input.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c008f15...e337eed. Read the comment docs.

@hi-rustin
Copy link
Contributor Author

@hi-rustin hi-rustin commented Dec 15, 2019

@afc163 @zombieJ Pass all tests, PTAL~

@hi-rustin
Copy link
Contributor Author

@hi-rustin hi-rustin commented Dec 17, 2019

ping~

@zombieJ zombieJ merged commit 1c4bae5 into ant-design:4.0-prepare Dec 19, 2019
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants