Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 TreeNode without icon white block #20274

Merged
merged 1 commit into from Dec 16, 2019
Merged

fix: 🐛 TreeNode without icon white block #20274

merged 1 commit into from Dec 16, 2019

Conversation

@afc163
Copy link
Member

afc163 commented Dec 16, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Reproduce link: https://codesandbox.io/s/immutable-cdn-brx1h

💡 Background and solution

  <Tree showLine showIcon defaultExpandAll>
    <TreeNode title="tree node" icon={<Icon type="setting" />}>
      <TreeNode title="No icon" key="0-1" />
      <TreeNode title="No icon" key="0-2" />
      <TreeNode title="No icon" key="0-1" />
    </TreeNode>
  </Tree>

wrong ui:

image

fixed to:

image

📝 Changelog

Language Changelog
🇺🇸 English Fix TreeNode without icon show white block in showIcon mode.
🇨🇳 Chinese 修复 TreeNode 不设置 icon 时会展示一个空白占位的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@auto-add-label auto-add-label bot added the bug label Dec 16, 2019
@pr-triage pr-triage bot added the PR: unreviewed label Dec 16, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Dec 16, 2019

Deploy preview for ant-design ready!

Built with commit d8206fb

https://deploy-preview-20274--ant-design.netlify.com

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Dec 16, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d8206fb:

Sandbox Source
antd reproduction template Configuration
great-hamilton-beyos PR
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #20274 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20274   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files         286      286           
  Lines        7735     7735           
  Branches     2130     2164   +34     
=======================================
  Hits         7566     7566           
  Misses        169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6666520...d8206fb. Read the comment docs.

@afc163 afc163 merged commit 9fa72ab into master Dec 16, 2019
37 checks passed
37 checks passed
lighthouse
Details
setup
Details
compile
Details
dist
Details
lint
Details
node
Details
lib
Details
es
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
DEP All dependencies are resolved
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
bundlesize Total bundle size is 586.93KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
codecov/patch Coverage not affected when comparing 6666520...d8206fb
Details
codecov/project 97.81% remains the same compared to 6666520
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@afc163 afc163 deleted the fix-tree-show-icon branch Dec 16, 2019
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Dec 16, 2019
@chenshuai2144 chenshuai2144 mentioned this pull request Dec 22, 2019
4 of 14 tasks complete
@LeoHuiyi

This comment has been minimized.

Copy link

LeoHuiyi commented Dec 25, 2019

image
官网Tree变成这样了

@LeoHuiyi

This comment has been minimized.

Copy link

LeoHuiyi commented Dec 25, 2019

@yoyo837

This comment has been minimized.

Copy link
Collaborator

yoyo837 commented Dec 25, 2019

@LeoHuiyi 开新issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.