Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tabs ink bar missing transition animation #20283

Merged
merged 1 commit into from Dec 16, 2019
Merged

Conversation

@afc163
Copy link
Member

afc163 commented Dec 16, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #20239

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Tabs ink bar missing transition animation.
🇨🇳 Chinese 修复 Tabs 高亮条宽度的 transition 过度动画失效的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@auto-add-label auto-add-label bot added the bug label Dec 16, 2019
@pr-triage pr-triage bot added the PR: unreviewed label Dec 16, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Dec 16, 2019

Deploy preview for ant-design ready!

Built with commit 05917f4

https://deploy-preview-20283--ant-design.netlify.com

close #20239
@afc163 afc163 force-pushed the fix-tabs-transition branch from b7fef0e to 05917f4 Dec 16, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #20283 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20283   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files         286      286           
  Lines        7735     7735           
  Branches     2178     2130   -48     
=======================================
  Hits         7566     7566           
  Misses        169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fa72ab...05917f4. Read the comment docs.

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Dec 16, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b7fef0e:

Sandbox Source
antd reproduction template Configuration
@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Dec 16, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 05917f4:

Sandbox Source
antd reproduction template Configuration
@afc163 afc163 merged commit f805d2e into master Dec 16, 2019
24 of 29 checks passed
24 of 29 checks passed
lighthouse
Details
setup
Details
compile
Details
dist
Details
lint
Details
node
Details
lib
Details
es
Details
License Compliance FOSSA is analyzing this commit
Details
ci/circleci: test_dist CircleCI is running your tests
Details
ci/circleci: test_dist_15 CircleCI is running your tests
Details
ci/circleci: test_es_15 CircleCI is running your tests
Details
ci/circleci: test_lib CircleCI is running your tests
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
bundlesize Total bundle size is 586.95KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@afc163 afc163 deleted the fix-tabs-transition branch Dec 16, 2019
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Dec 16, 2019
@chenshuai2144 chenshuai2144 mentioned this pull request Dec 22, 2019
4 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.