Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: πŸ’„ optimize Steps labelPlacement vertical UI #20325

Merged
merged 1 commit into from Dec 18, 2019
Merged

Conversation

@afc163
Copy link
Member

afc163 commented Dec 18, 2019

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

πŸ”— Related issue link

https://codesandbox.io/s/friendly-moore-974l8

πŸ’‘ Background and solution

image


This PR fixes

image

to

image

πŸ“ Changelog

Language Changelog
πŸ‡ΊπŸ‡Έ English Optimize Steps subTile UI when labelPlacement="vertical".
πŸ‡¨πŸ‡³ Chinese δΌ˜εŒ– Steps subTile 在 labelPlacement="vertical" δΈ‹ηš„ε±•ηŽ°ζ–ΉεΌγ€‚

β˜‘οΈ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@auto-add-label auto-add-label bot added the bug label Dec 18, 2019
@pr-triage pr-triage bot added the PR: unreviewed label Dec 18, 2019
@afc163 afc163 force-pushed the fix-steps-item-width branch from e06bbac to a2765fe Dec 18, 2019
@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Dec 18, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e06bbac:

Sandbox Source
antd reproduction template Configuration
bitter-frost-hcc54 PR
@netlify

This comment has been minimized.

Copy link

netlify bot commented Dec 18, 2019

Deploy preview for ant-design failed.

Built with commit e06bbac

https://app.netlify.com/sites/ant-design/deploys/5df9f1e06aca54000af5e120

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Dec 18, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a2765fe:

Sandbox Source
antd reproduction template Configuration
gracious-moore-jyljx PR
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #20325 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20325   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files         286      286           
  Lines        7735     7735           
  Branches     2130     2130           
=======================================
  Hits         7566     7566           
  Misses        169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update aa0b1c5...a2765fe. Read the comment docs.

@afc163 afc163 merged commit 7a2d1f2 into master Dec 18, 2019
31 checks passed
31 checks passed
lighthouse
Details
setup
Details
compile
Details
dist
Details
lint
Details
node
Details
lib
Details
es
Details
License Compliance All checks passed.
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
bundlesize Total bundle size is 586.96KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
codecov/patch Coverage not affected when comparing aa0b1c5...a2765fe
Details
codecov/project 97.81% remains the same compared to aa0b1c5
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@afc163 afc163 deleted the fix-steps-item-width branch Dec 18, 2019
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Dec 18, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Dec 18, 2019

Deploy preview for ant-design failed.

Built with commit a2765fe

https://app.netlify.com/sites/ant-design/deploys/5df9f2b770db5000083ba9f8

@chenshuai2144 chenshuai2144 mentioned this pull request Dec 23, 2019
5 of 14 tasks complete
afc163 added a commit that referenced this pull request Dec 24, 2019
* docs: add 20325 in 3.26.4 changelog

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.