Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disallow auto focus input after triggering "onSearch" event in m… #20332

Merged
merged 1 commit into from Dec 19, 2019

Conversation

@YaoKaiLun
Copy link
Contributor

YaoKaiLun commented Dec 18, 2019

…obile and tablet devices

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #20297

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Disallow auto focus input after triggering "onSearch" event in mobile and tablet devices
🇨🇳 Chinese 修复移动端点击搜索后,自动聚焦输入框,导致弹出键盘的问题

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
…obile and tablet devices
@auto-add-label auto-add-label bot added the bug label Dec 18, 2019
@pr-triage pr-triage bot added the PR: unreviewed label Dec 18, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Dec 18, 2019

Deploy preview for ant-design ready!

Built with commit 375d9f8

https://deploy-preview-20332--ant-design.netlify.com

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Dec 18, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 375d9f8:

Sandbox Source
antd reproduction template Configuration
@yoyo837

This comment has been minimized.

Copy link
Collaborator

yoyo837 commented Dec 18, 2019

In my opinion, I think it's much better to use "prop" to control that. #20297 (comment)

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #20332 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20332      +/-   ##
==========================================
+ Coverage   97.81%   97.81%   +<.01%     
==========================================
  Files         286      286              
  Lines        7735     7736       +1     
  Branches     2178     2176       -2     
==========================================
+ Hits         7566     7567       +1     
  Misses        169      169
Impacted Files Coverage Δ
components/input/Search.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a2d1f2...375d9f8. Read the comment docs.

@afc163 afc163 merged commit 32744e7 into ant-design:master Dec 19, 2019
27 checks passed
27 checks passed
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 289 new files uploaded
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
codecov/patch 100% of diff hit (target 97.81%)
Details
codecov/project 97.81% (+<.01%) compared to 7a2d1f2
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Dec 19, 2019
@chenshuai2144 chenshuai2144 mentioned this pull request Dec 22, 2019
4 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.