Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filters define error in onChange #20337

Merged
merged 1 commit into from Dec 19, 2019
Merged

Conversation

@MrHeer
Copy link
Contributor

MrHeer commented Dec 18, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #20270

💡 Background and solution

-    filters: Record<keyof T, string[]>,
+    filters: Partial<Record<keyof T, string[]>>,

📝 Changelog

Language Changelog
🇺🇸 English update filters define in onChange
🇨🇳 Chinese 更新 onChang 中 filters 的定义

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@auto-add-label auto-add-label bot added the bug label Dec 18, 2019
@pr-triage pr-triage bot added the PR: unreviewed label Dec 18, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Dec 18, 2019

Deploy preview for ant-design ready!

Built with commit 8a4301b

https://deploy-preview-20337--ant-design.netlify.com

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Dec 18, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8a4301b:

Sandbox Source
antd reproduction template Configuration
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #20337 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20337   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files         286      286           
  Lines        7735     7735           
  Branches     2178     2164   -14     
=======================================
  Hits         7566     7566           
  Misses        169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a2d1f2...8a4301b. Read the comment docs.

@yoyo837 yoyo837 merged commit ea9e9fb into ant-design:master Dec 19, 2019
27 checks passed
27 checks passed
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 218 new files uploaded
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
codecov/patch Coverage not affected when comparing 7a2d1f2...8a4301b
Details
codecov/project 97.81% remains the same compared to 7a2d1f2
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Dec 19, 2019
@MrHeer MrHeer deleted the MrHeer:fix-filter-define branch Dec 19, 2019
@chenshuai2144 chenshuai2144 mentioned this pull request Dec 22, 2019
4 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.