Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ๐Ÿ› Tag onClick triggered when close #20355

Merged
merged 1 commit into from Dec 19, 2019
Merged

fix: ๐Ÿ› Tag onClick triggered when close #20355

merged 1 commit into from Dec 19, 2019

Conversation

@afc163
Copy link
Member

afc163 commented Dec 19, 2019

๐Ÿค” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

๐Ÿ”— Related issue link

close #20344

๐Ÿ’ก Background and solution

๐Ÿ“ Changelog

Language Changelog
๐Ÿ‡บ๐Ÿ‡ธ English Fix Tag onClick been triggered when close it.
๐Ÿ‡จ๐Ÿ‡ณ Chinese ไฟฎๅค Tag ๅ…ณ้—ญๆ—ถ onClick ่ขซ่งฆๅ‘็š„้—ฎ้ข˜ใ€‚

โ˜‘๏ธ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@auto-add-label auto-add-label bot added the bug label Dec 19, 2019
@pr-triage pr-triage bot added the PR: unreviewed label Dec 19, 2019
Copy link

tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@pr-triage pr-triage bot removed the PR: unreviewed label Dec 19, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Dec 19, 2019

Deploy preview for ant-design ready!

Built with commit 752fd47

https://deploy-preview-20355--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #20355 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20355      +/-   ##
==========================================
+ Coverage   97.81%   97.81%   +<.01%     
==========================================
  Files         286      286              
  Lines        7736     7737       +1     
  Branches     2179     2165      -14     
==========================================
+ Hits         7567     7568       +1     
  Misses        169      169
Impacted Files Coverage ฮ”
components/tag/index.tsx 98.14% <100%> (+0.03%) โฌ†๏ธ

Continue to review full report at Codecov.

Legend - Click here to learn more
ฮ” = absolute <relative> (impact), รธ = not affected, ? = missing data
Powered by Codecov. Last update 38dab1f...752fd47. Read the comment docs.

@afc163 afc163 merged commit 6e27c62 into master Dec 19, 2019
34 of 37 checks passed
34 of 37 checks passed
lighthouse
Details
setup
Details
compile
Details
dist
Details
lint
Details
node
Details
lib
Details
es
Details
License Compliance FOSSA is analyzing this commit
Details
ci/codesandbox Building packages...
Details
netlify/ant-design/deploy-preview Deploy preview processing.
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 298 new files uploaded
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
bundlesize Total bundle size is 587.31KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 97.81%)
Details
codecov/project 97.81% (+<.01%) compared to 38dab1f
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@afc163 afc163 deleted the fix-tag-on-close branch Dec 19, 2019
@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Dec 19, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 752fd47:

Sandbox Source
antd reproduction template Configuration
awesome-water-81zuv Issue #20344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You canโ€™t perform that action at this time.