Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Form): feedback icon with input suffix display not correct #20363

Merged

Conversation

@shaodahong
Copy link
Collaborator

shaodahong commented Dec 20, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Fixes #20358

Checklist

  • Feedback
  • Feedback with the suffix
  • Feedback with suffix (contain clear icon)

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Form feedback icon combine Input suffix display not correct
🇨🇳 Chinese 修复 Form feedback 图标结合 Input suffix 显示不正确

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/form/demo/register.md

@auto-add-label auto-add-label bot added the bug label Dec 20, 2019
@pr-triage pr-triage bot added the PR: unreviewed label Dec 20, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Dec 20, 2019

Deploy preview for ant-design ready!

Built with commit 56448ec

https://deploy-preview-20363--ant-design.netlify.com

@shaodahong shaodahong changed the title fix(From): feedback icon with input suffix display not correct fix(Form): feedback icon with input suffix display not correct Dec 20, 2019
@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Dec 20, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 56448ec:

Sandbox Source
antd reproduction template Configuration
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 20, 2019

Codecov Report

Merging #20363 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20363   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files         286      286           
  Lines        7737     7737           
  Branches     2176     2165   -11     
=======================================
  Hits         7568     7568           
  Misses        169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e27c62...56448ec. Read the comment docs.

@afc163 afc163 merged commit 74082de into ant-design:master Dec 20, 2019
26 checks passed
26 checks passed
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 218 new files uploaded
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
codecov/patch Coverage not affected when comparing 6e27c62...56448ec
Details
codecov/project 97.81% remains the same compared to 6e27c62
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Dec 20, 2019
@shaodahong shaodahong deleted the shaodahong:fix-form-feedback-with-input-suffix branch Dec 20, 2019
@zombieJ

This comment has been minimized.

Copy link
Member

zombieJ commented Dec 20, 2019

@shaodahong , 合一下 4.0 看看会不会失效。

@shaodahong

This comment has been minimized.

Copy link
Collaborator Author

shaodahong commented Dec 20, 2019

@shaodahong , 合一下 4.0 看看会不会失效。

master 合到 4.0 么

@zombieJ

This comment has been minimized.

Copy link
Member

zombieJ commented Dec 20, 2019

嗯

@shaodahong

This comment has been minimized.

Copy link
Collaborator Author

shaodahong commented Dec 20, 2019

好的,迟点我合下

@shaodahong

This comment has been minimized.

Copy link
Collaborator Author

shaodahong commented Dec 20, 2019

@zombieJ 合到 4.0 这个间距没了,简单看了下是图标 i 标签换成 span 引起的

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.