Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload preview not support ico file type issue(#20360) #20375

Merged
merged 1 commit into from Dec 22, 2019

Conversation

@Rustin-Liu
Copy link
Contributor

Rustin-Liu commented Dec 22, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#20360

💡 Background and solution

Add ico type.

📝 Changelog

Language Changelog
🇺🇸 English fix upload preview not support ico file type issue
🇨🇳 Chinese 修复 upload 组件预览不支持 ico 文件问题

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@auto-add-label auto-add-label bot added the bug label Dec 22, 2019
@pr-triage pr-triage bot added the PR: unreviewed label Dec 22, 2019
Copy link

tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify

This comment has been minimized.

Copy link

netlify bot commented Dec 22, 2019

Deploy preview for ant-design ready!

Built with commit 6226056

https://deploy-preview-20375--ant-design.netlify.com

@Rustin-Liu Rustin-Liu force-pushed the Rustin-Liu:rustin-patch-upload branch from 6962a2d to 6226056 Dec 22, 2019
@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Dec 22, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6226056:

Sandbox Source
antd reproduction template Configuration
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 22, 2019

Codecov Report

Merging #20375 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20375      +/-   ##
==========================================
+ Coverage   97.81%   97.81%   +<.01%     
==========================================
  Files         286      286              
  Lines        7737     7739       +2     
  Branches     2176     2181       +5     
==========================================
+ Hits         7568     7570       +2     
  Misses        169      169
Impacted Files Coverage Δ
components/upload/utils.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74082de...6226056. Read the comment docs.

@afc163 afc163 merged commit 92169c4 into ant-design:master Dec 22, 2019
26 checks passed
26 checks passed
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
codecov/patch 100% of diff hit (target 97.81%)
Details
codecov/project 97.81% (+<.01%) compared to 74082de
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Dec 22, 2019
@chenshuai2144 chenshuai2144 mentioned this pull request Dec 22, 2019
4 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.