Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tab bar animated style #20417

Merged
merged 2 commits into from Dec 25, 2019
Merged

fix: tab bar animated style #20417

merged 2 commits into from Dec 25, 2019

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Dec 24, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #20415

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix tab style of tabs component when animated={false}
🇨🇳 Chinese 修复 tabs 组件 开启 animated={false} tab 样式

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Dec 24, 2019

Deploy preview for ant-design ready!

Built with commit 8d9d325

https://deploy-preview-20417--ant-design.netlify.com

@xrkffgg xrkffgg changed the title fix: tab-bar animated style fix: tab bar animated style Dec 24, 2019
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 24, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8d9d325:

Sandbox Source
antd reproduction template Configuration

@@ -33,7 +33,7 @@
height: 2px;
background-color: @tabs-ink-bar-color;
transform-origin: 0 0;
opacity: 0;
opacity: 1;
Copy link
Member

@afc163 afc163 Dec 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 opacity 可以干掉了。

Copy link
Member Author

@xrkffgg xrkffgg Dec 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@@ -405,14 +405,12 @@

.@{tab-prefix-cls}-top .@{tab-prefix-cls}-ink-bar-animated,
.@{tab-prefix-cls}-bottom .@{tab-prefix-cls}-ink-bar-animated {
opacity: 1;
transition: transform 0.3s @ease-in-out, width 0.2s @ease-in-out, left 0.3s @ease-in-out,
opacity 0.3s;
Copy link
Member

@afc163 afc163 Dec 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有这里的 opacity 0.3s。

@afc163
Copy link
Member

afc163 commented Dec 24, 2019

image

写成 close #xx 或者 fix #xx 可以关联关闭 issue。

@codecov
Copy link

codecov bot commented Dec 24, 2019

Codecov Report

Merging #20417 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20417   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files         286      286           
  Lines        7739     7739           
  Branches     2178     2181    +3     
=======================================
  Hits         7570     7570           
  Misses        169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ae0984...8d9d325. Read the comment docs.

@xrkffgg
Copy link
Member Author

xrkffgg commented Dec 25, 2019

@afc163
我有点记不太清楚了啊。上一个版本官网是没有这2个的 地方,而只有本地 dev 开发有的。所以我猜想,是不是这个版本的官方使用了开发环境。

  • 1
    image
  • 2
    image

@afc163 afc163 merged commit 847f5fc into ant-design:master Dec 25, 2019
26 checks passed
@xrkffgg xrkffgg deleted the fix-tab-bar branch Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab bar is not visible when setting animated={false}
2 participants