Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert Table return first page after sort #20507

Merged
merged 1 commit into from Dec 28, 2019
Merged

fix: revert Table return first page after sort #20507

merged 1 commit into from Dec 28, 2019

Conversation

@afc163
Copy link
Member

afc163 commented Dec 27, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #16978
close #17770
close #17648
close #18099
close #17075
close #19369

💡 Background and solution

#17020 之后的相关反馈太多,需要再权衡一下:#16978 (comment)

📝 Changelog

Language Changelog
🇺🇸 English Revert Table return fisrt page after sort.
🇨🇳 Chinese 回滚 Table 排序之后回到第一页的行为。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@auto-add-label auto-add-label bot added the bug label Dec 27, 2019
@pr-triage pr-triage bot added the PR: unreviewed label Dec 27, 2019
Copy link

tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Dec 27, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2c10e9e:

Sandbox Source
antd reproduction template Configuration
focused-goldstine-4nrpd Issue #17648
@netlify

This comment has been minimized.

Copy link

netlify bot commented Dec 27, 2019

Deploy preview for ant-design ready!

Built with commit 2c10e9e

https://deploy-preview-20507--ant-design.netlify.com

@zombieJ

This comment has been minimized.

Copy link
Member

zombieJ commented Dec 28, 2019

test failed.

close #16978
close #17770
close #17648
close #18099
close #17075
close #19369
@afc163 afc163 force-pushed the fix-table-sort branch from 0524a79 to 2c10e9e Dec 28, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 28, 2019

Codecov Report

Merging #20507 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20507      +/-   ##
==========================================
- Coverage   97.81%   97.81%   -0.01%     
==========================================
  Files         286      286              
  Lines        7739     7735       -4     
  Branches     2133     2177      +44     
==========================================
- Hits         7570     7566       -4     
  Misses        169      169
Impacted Files Coverage Δ
components/table/Table.tsx 99.49% <ø> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 670bd4b...2c10e9e. Read the comment docs.

@zombieJ zombieJ merged commit df8f343 into master Dec 28, 2019
36 checks passed
36 checks passed
lighthouse
Details
setup
Details
compile
Details
dist
Details
lint
Details
node
Details
lib
Details
es
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
bundlesize Total bundle size is 591.97KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
codecov/patch Coverage not affected when comparing 670bd4b...2c10e9e
Details
codecov/project 97.81% (-0.01%) compared to 670bd4b
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@zombieJ zombieJ deleted the fix-table-sort branch Dec 28, 2019
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.