Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Object.prototype.toString to check object #20546

Merged
merged 1 commit into from Dec 30, 2019
Merged

fix: use Object.prototype.toString to check object #20546

merged 1 commit into from Dec 30, 2019

Conversation

@DiamondYuan
Copy link
Collaborator

DiamondYuan commented Dec 30, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

close #20528

馃挕 Background and solution

use Object.prototype.toString instead of typeof

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@auto-add-label auto-add-label bot added the bug label Dec 30, 2019
@pr-triage pr-triage bot added the PR: unreviewed label Dec 30, 2019
Copy link

tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify

This comment has been minimized.

Copy link

netlify bot commented Dec 30, 2019

Deploy preview for ant-design ready!

Built with commit 257941a

https://deploy-preview-20546--ant-design.netlify.com

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Dec 30, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 257941a:

Sandbox Source
antd reproduction template Configuration
components/message/index.tsx Outdated Show resolved Hide resolved
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 30, 2019

Codecov Report

Merging #20546 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20546      +/-   ##
==========================================
+ Coverage   97.81%   97.81%   +<.01%     
==========================================
  Files         286      286              
  Lines        7735     7737       +2     
  Branches     2177     2181       +4     
==========================================
+ Hits         7566     7568       +2     
  Misses        169      169
Impacted Files Coverage 螖
components/message/index.tsx 94.36% <100%> (+0.16%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 8ea9356...257941a. Read the comment docs.

@afc163 afc163 merged commit 4297f33 into master Dec 30, 2019
36 of 37 checks passed
36 of 37 checks passed
lighthouse
Details
setup
Details
compile
Details
dist
Details
lint
Details
node
Details
lib
Details
es
Details
License Compliance FOSSA is analyzing this commit
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
bundlesize Total bundle size is 591.95KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
codecov/patch 100% of diff hit (target 97.81%)
Details
codecov/project 97.81% (+<.01%) compared to 8ea9356
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@afc163 afc163 deleted the fix/20528 branch Dec 30, 2019
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Dec 30, 2019
afc163 added a commit that referenced this pull request Jan 3, 2020
* 馃拕 Improve Step `type="navigation"` UI in small screen (#20545)

close #19877

* fix: use Object.prototype.toString to check object (#20546)

close #20528

* Fix image misplacing (#20552)

Switched the images of "The keyword of the user query is only displayed in three categories, Topics, Questions and Articles." and "The number of categories the keyword of the user query belongs to is uncertain."

* fix: 馃拕 Remove Input.Password value attribute from dom (#20544)

* 馃拕 Remove Input.Password value attribute in dom

close #20541
close #7761
close #19959
close #20536
close #12672
close #10952

*  fix test coverage

* 馃悰 fix defaultValue create `value` attribute in Input.Password

* 馃啓 upgrade stylelint-order (#20585)

* fix: url 404 (#20589)

* fix url 404

* update url

* Update colors.en-US.md (#20606)

* Revert "Update colors.en-US.md (#20606)" (#20607)

This reverts commit c513296.

* docs: update Modal docs (#20612)

* doc: update Modal docs

* doc: update modal en-US doc

Co-authored-by: DiamondYuan <541832074@qq.com>
Co-authored-by: Yaindrop <yuan_dian@live.com>
Co-authored-by: jiang <155259966@qq.com>
Co-authored-by: myeunhyuk <39618466+myeunhyuk@users.noreply.github.com>
Co-authored-by: 浜岃揣鏈哄櫒浜 <smith3816@gmail.com>
Co-authored-by: vagusX <vagusX@users.noreply.github.com>
@zombieJ zombieJ mentioned this pull request Jan 3, 2020
1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.