Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Form & ConfigProvider support component size #20570

Merged
merged 10 commits into from Jan 3, 2020
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 31, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

close #17570
close #20174

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Form & ConfigProvider support component size
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/config-provider/demo/size.md
View rendered components/config-provider/index.en-US.md
View rendered components/config-provider/index.zh-CN.md
View rendered components/form/demo/size.md
View rendered components/form/index.en-US.md
View rendered components/form/index.zh-CN.md

@netlify
Copy link

@netlify netlify bot commented Dec 31, 2019

Deploy preview for ant-design ready!

Built with commit 2b229d9

https://deploy-preview-20570--ant-design.netlify.com

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Dec 31, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a7a879a:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Dec 31, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 995a8ae:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Dec 31, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2b229d9:

Sandbox Source
antd reproduction template Configuration

@afc163
Copy link
Member

@afc163 afc163 commented Dec 31, 2019

鎰熻浼氬拰 #19380 鏈夊ぇ閲忓啿绐侊紝鏈濂芥妸 #19380 鍚堝苟浜嗗啀鐢辨垜浠嚜宸卞湪杩欎釜 PR 閲岃В鍐冲啿绐併

@codecov
Copy link

@codecov codecov bot commented Jan 2, 2020

Codecov Report

Merging #20570 into 4.0-prepare will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           4.0-prepare   #20570      +/-   ##
===============================================
+ Coverage        97.54%   97.56%   +0.01%     
===============================================
  Files              294      295       +1     
  Lines             6766     6805      +39     
  Branches          1865     1841      -24     
===============================================
+ Hits              6600     6639      +39     
  Misses             166      166
Impacted Files Coverage 螖
components/form/Form.tsx 100% <酶> (酶) 猬嗭笍
components/button/index.tsx 100% <酶> (酶) 猬嗭笍
components/button/button-group.tsx 100% <酶> (酶) 猬嗭笍
components/input/ClearableLabeledInput.tsx 100% <酶> (酶) 猬嗭笍
components/table/Table.tsx 96.61% <100%> (+0.05%) 猬嗭笍
components/config-provider/index.tsx 91.66% <100%> (酶) 猬嗭笍
components/tree-select/index.tsx 97.72% <100%> (+0.29%) 猬嗭笍
components/select/index.tsx 97.61% <100%> (+0.18%) 猬嗭笍
components/date-picker/generatePicker.tsx 97.02% <100%> (+0.09%) 猬嗭笍
components/button/button.tsx 100% <100%> (酶) 猬嗭笍
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9913f99...2b229d9. Read the comment docs.

@zombieJ zombieJ marked this pull request as ready for review Jan 2, 2020
@zombieJ zombieJ requested a review from afc163 Jan 2, 2020
@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Jan 2, 2020

Merge 4.0-prepare. Please help to check.

@afc163
Copy link
Member

@afc163 afc163 commented Jan 3, 2020

Table 鍜 Card 瑕佷笉瑕佹敮鎸佷竴涓嬶紝涓嶈繃瑕佹敞鎰忚繖涓ら粯璁ゅぇ灏忔儏鍐典笉澶竴鏍枫

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Jan 3, 2020

Card 鍙互锛屽拰 Switch 涓鏍峰彧鏈 defaultsmall銆俆able 鐨勮瘽姣旇緝铔嬬柤锛岄粯璁ゅ氨鏄 large銆傚鏋滄槸杩欐牱鐨勮瘽锛岄偅 componentSize 灏变笉鏄 large | default | small銆傝屾槸 large | 'middle' | 'small'銆傞粯璁や粈涔堥兘涓嶅~锛岃窡鐫缁勪欢鑷繁璧般傚鏋滆缃簡灏辫窡鐫璁剧疆璧帮紝鍗 size='middle' 鐨勬椂鍊欙紝璁剧疆 Table 涔熶负 middle銆傝繖鏍峰浣曪紵

@afc163
Copy link
Member

@afc163 afc163 commented Jan 3, 2020

濡傛灉璁剧疆浜嗗氨璺熺潃璁剧疆璧帮紝鍗 size='middle' 鐨勬椂鍊欙紝璁剧疆 Table 涔熶负 middle銆傝繖鏍峰浣曪紵

鏄繖鏍风殑銆

@afc163
Copy link
Member

@afc163 afc163 commented Jan 3, 2020

will close #20174 too

afc163
afc163 approved these changes Jan 3, 2020
@zombieJ zombieJ merged commit 5ebac5f into 4.0-prepare Jan 3, 2020
31 checks passed
@zombieJ zombieJ deleted the form-sizing branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants