Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Input.Group align in Form.Item #20681

Merged
merged 1 commit into from Jan 6, 2020
Merged

fix: Input.Group align in Form.Item #20681

merged 1 commit into from Jan 6, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jan 6, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

No more override css hacks.

image

to

image

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese 修复 Form 下 Input.Group 偏上一像素的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

@netlify netlify bot commented Jan 6, 2020

Deploy preview for ant-design ready!

Built with commit 76ac03b

https://deploy-preview-20681--ant-design.netlify.com

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 76ac03b:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jan 6, 2020

Codecov Report

Merging #20681 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20681   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files         295      295           
  Lines        6836     6836           
  Branches     1855     1888   +33     
=======================================
  Hits         6668     6668           
  Misses        168      168

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74c64ec...76ac03b. Read the comment docs.

@afc163
Copy link
Member Author

@afc163 afc163 commented Jan 6, 2020

close #20616 in 3.x too.

@afc163 afc163 merged commit faa9692 into master Jan 6, 2020
31 of 33 checks passed
@afc163 afc163 deleted the fix-form-align branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant