Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(3.x): Input.Group 1px bug in vertical layout form #20685

Merged
merged 1 commit into from Jan 6, 2020

Conversation

@afc163
Copy link
Member

afc163 commented Jan 6, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #20616

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Input.Group inside <Form layout="vertical" > 1px bug.
🇨🇳 Chinese 修复 <Form layout="vertical" > 内 Input.Group 偏上一像素的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@pr-triage pr-triage bot added the PR: unreviewed label Jan 6, 2020
@afc163 afc163 changed the title fixInput.Group 1px bug in vertical layout form fix(3.x): Input.Group 1px bug in vertical layout form Jan 6, 2020
@auto-add-label auto-add-label bot added the bug label Jan 6, 2020
@netlify

This comment has been minimized.

Copy link

netlify bot commented Jan 6, 2020

Deploy preview for ant-design ready!

Built with commit 39f3fdd

https://deploy-preview-20685--ant-design.netlify.com

@afc163 afc163 changed the base branch from master to 3.x-stable Jan 6, 2020
@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Jan 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 39f3fdd:

Sandbox Source
antd reproduction template Configuration
antd reproduction template Issue #20616
antd reproduction template Issue #20616
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #20685 into 3.x-stable will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           3.x-stable   #20685   +/-   ##
===========================================
  Coverage       97.81%   97.81%           
===========================================
  Files             286      286           
  Lines            7749     7749           
  Branches         2172     2172           
===========================================
  Hits             7580     7580           
  Misses            169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0520b84...39f3fdd. Read the comment docs.

@afc163

This comment has been minimized.

Copy link
Member Author

afc163 commented Jan 6, 2020

@afc163 afc163 merged commit c6eafe8 into 3.x-stable Jan 6, 2020
35 of 37 checks passed
35 of 37 checks passed
lighthouse
Details
setup
Details
compile
Details
dist
Details
lint
Details
node
Details
lib
Details
es
Details
Mixed content - ant-design
Details
Redirect rules - ant-design
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 218 new files uploaded
Details
DEP All dependencies are resolved
License Compliance All checks passed.
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
bundlesize Total bundle size is 592.13KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
codecov/patch Coverage not affected when comparing 0520b84...39f3fdd
Details
codecov/project 97.81% remains the same compared to 0520b84
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details
@afc163 afc163 deleted the fix-form-align-1px-bug branch Jan 6, 2020
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jan 6, 2020
@yoyo837 yoyo837 added the 3.x label Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.