Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FormItem should not trigger feedback className without hasFeedback #20691

Merged
merged 1 commit into from Jan 6, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 6, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

fix #20680

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Fix Form.Item add additional feedback style when hasFeedback is not set.
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

@netlify netlify bot commented Jan 6, 2020

Deploy preview for ant-design ready!

Built with commit f1d617b

https://deploy-preview-20691--ant-design.netlify.com

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f1d617b:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jan 6, 2020

Codecov Report

Merging #20691 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20691   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files         295      295           
  Lines        6836     6836           
  Branches     1898     1855   -43     
=======================================
  Hits         6668     6668           
  Misses        168      168
Impacted Files Coverage 螖
components/form/FormItem.tsx 98.88% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update faa9692...f1d617b. Read the comment docs.

@zombieJ zombieJ merged commit 17dd0d2 into master Jan 6, 2020
32 checks passed
@zombieJ zombieJ deleted the fix-form-input-shaking branch Jan 6, 2020
@yoyo837 yoyo837 mentioned this pull request Jan 14, 2020
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant