Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Slider Tooltip not follow handler #20699

Merged
merged 2 commits into from Jan 6, 2020
Merged

fix: Slider Tooltip not follow handler #20699

merged 2 commits into from Jan 6, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 6, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

fix #20677

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Fix Slider's Tooltip not follow handle.
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

@netlify netlify bot commented Jan 6, 2020

Deploy preview for ant-design ready!

Built with commit cf782da

https://deploy-preview-20699--ant-design.netlify.com

components/slider/index.tsx Outdated Show resolved Hide resolved
components/slider/index.tsx Outdated Show resolved Hide resolved
@afc163
Copy link
Member

@afc163 afc163 commented Jan 6, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cf782da:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jan 6, 2020

Codecov Report

Merging #20699 into master will decrease coverage by 0.06%.
The diff coverage is 76.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20699      +/-   ##
==========================================
- Coverage   97.54%   97.47%   -0.07%     
==========================================
  Files         295      296       +1     
  Lines        6842     6863      +21     
  Branches     1900     1902       +2     
==========================================
+ Hits         6674     6690      +16     
- Misses        168      173       +5
Impacted Files Coverage 螖
components/slider/index.tsx 90% <酶> (酶) 猬嗭笍
components/slider/SliderTooltip.tsx 76.19% <76.19%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 6017b3f...cf782da. Read the comment docs.

@shaodahong
Copy link
Member

@shaodahong shaodahong commented Jan 6, 2020

鐐逛竴涓嬮〉闈㈠崱姝讳簡

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Jan 6, 2020

鍡紝濂藉儚鏄湁 BUG銆侳C 閲岀湅鏉ヤ笉鑳界洿鎺ヤ緷璧 useEffect銆

@zombieJ zombieJ changed the title fix: Slider Tooltip not follow handler [WIP] fix: Slider Tooltip not follow handler Jan 6, 2020
@pr-triage pr-triage bot removed the PR: unreviewed label Jan 6, 2020
@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Jan 6, 2020

鎵惧埌鍘熷洜浜嗭紝鏂扮増鐨 rc-trigger 閫氳繃 setState 鏉ユ帶鍒剁姸鎬佹洿鏂帮紝鐒跺悗鍐呴儴鐨 rc-align 姣忔 force align 閮戒細瑙﹀彂 onAlign 瀵艰嚧涓婂眰鐨 rc-trigger 鍙堥噸缃姸鎬併傜劧鍚庢寰幆浜嗐

瑙d簡鎴戝綋鍓嶅ソ濂囦负鍟 Trigger 鍜 Align 閲屽悇绉嶈皟鐢 dom 涓嶇敤 state 涔嬭皽鈥︹

鎴戞崲绉嶆柟寮忓幓瑙e畠銆

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Jan 6, 2020

鎹簡绉嶅疄鐜帮紝Tooltip 鍑虹幇鐨勬椂鍊欙紝鍋氶噸缃 align 澶勭悊銆傚悎瀹屽悗锛屾垜鍘绘妸 keepAlign 鍒犱簡銆

@zombieJ zombieJ changed the title [WIP] fix: Slider Tooltip not follow handler fix: Slider Tooltip not follow handler Jan 6, 2020
@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Jan 6, 2020

@shaodahong, 鍐嶈瘯璇曘

@shaodahong
Copy link
Member

@shaodahong shaodahong commented Jan 6, 2020

rc-slider 涔熻杩欎箞瑙e喅锛

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Jan 6, 2020

rc-slider 涓嶇锛岀敤鎴疯嚜宸卞畾涔夎嚜宸辩殑 Tooltip 灏辫浜嗐

@shaodahong
Copy link
Member

@shaodahong shaodahong commented Jan 6, 2020

濂界殑锛岄偅娌¢棶棰樹簡

@zombieJ zombieJ merged commit c5a40fc into master Jan 6, 2020
31 of 32 checks passed
@zombieJ zombieJ deleted the fix-slider branch Jan 6, 2020
@shaodahong
Copy link
Member

@shaodahong shaodahong commented Jan 6, 2020

rc-slider 涓嶇锛岀敤鎴疯嚜宸卞畾涔夎嚜宸辩殑 Tooltip 灏辫浜嗐

rc-slide demo 浼拌瑕佹洿鏂颁笅

@afc163
Copy link
Member

@afc163 afc163 commented Jan 7, 2020

鎴戜粛鐒惰寰 https://github.com/react-component/slider/pull/615/files#r363582675 杩欐牱瑙e喅姣旇緝褰诲簳銆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants