Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Card cover image get skretched #20701

Merged
merged 1 commit into from Jan 6, 2020
Merged

fix: Card cover image get skretched #20701

merged 1 commit into from Jan 6, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jan 6, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #20698

💡 Background and solution

Image max-width 的方案会导致 hover 卡片时边缘依然出现白色边框(这里是需要去掉的)。

cc @zombieJ

  • 图片宽度不够不能拉伸。
  • Hover 时图片两边不能出现白色边框。

📝 Changelog

Language Changelog
🇺🇸 English Fix Card cover image get skretched
🇨🇳 Chinese 修复 Card 封面图片被拉伸的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

@netlify netlify bot commented Jan 6, 2020

Deploy preview for ant-design ready!

Built with commit 4e4e488

https://deploy-preview-20701--ant-design.netlify.com

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4e4e488:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jan 6, 2020

Codecov Report

Merging #20701 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20701   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files         295      295           
  Lines        6842     6842           
  Branches     1900     1856   -44     
=======================================
  Hits         6674     6674           
  Misses        168      168

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6017b3f...4e4e488. Read the comment docs.

@zombieJ zombieJ merged commit 78f5607 into master Jan 6, 2020
32 checks passed
@zombieJ zombieJ deleted the fix-card-image branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants