-
-
Notifications
You must be signed in to change notification settings - Fork 50.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Cascader search bug when fieldNames existed #20720
Conversation
and label/value have same field name close #20619
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
Deploy preview for ant-design ready! Built with commit 861f65d |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 861f65d:
|
Codecov Report
@@ Coverage Diff @@
## master #20720 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 296 296
Lines 6863 6863
Branches 1905 1905
=======================================
Hits 6690 6690
Misses 173 173
Continue to review full report at Codecov.
|
and label/value have same field name close #20619
@afc163 这个问题在官方4.4.2文档示例中还是存在,我没弄明白哪个版本是正常的。。 |
🤔 This is a ...
🔗 Related issue link
close #20619
💡 Background and solution
when label/value have same field name.
📝 Changelog
fieldNames
is existed and label/value share same name.fieldNames
中label
和value
共用一个值时搜索功能失效的问题。☑️ Self Check before Merge