Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cascader search bug when fieldNames existed #20720

Merged
merged 1 commit into from Jan 7, 2020
Merged

Conversation

@afc163
Copy link
Member

afc163 commented Jan 7, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #20619

💡 Background and solution

when label/value have same field name.

📝 Changelog

Language Changelog
🇺🇸 English Fix Cascader search bug when fieldNames is existed and label/value share same name.
🇨🇳 Chinese 修复 Cascader fieldNames 中 label 和 value 共用一个值时搜索功能失效的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
and label/value have same field name

close #20619
@auto-add-label auto-add-label bot added the bug label Jan 7, 2020
@pr-triage pr-triage bot added the PR: unreviewed label Jan 7, 2020
Copy link

tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@pr-triage pr-triage bot removed the PR: unreviewed label Jan 7, 2020
@netlify

This comment has been minimized.

Copy link

netlify bot commented Jan 7, 2020

Deploy preview for ant-design ready!

Built with commit 861f65d

https://deploy-preview-20720--ant-design.netlify.com

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Jan 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 861f65d:

Sandbox Source
antd reproduction template Configuration
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #20720 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20720   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files         296      296           
  Lines        6863     6863           
  Branches     1905     1905           
=======================================
  Hits         6690     6690           
  Misses        173      173
Impacted Files Coverage Δ
components/cascader/index.tsx 97.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5398f24...861f65d. Read the comment docs.

@afc163 afc163 merged commit 0ceb6cc into master Jan 7, 2020
32 checks passed
32 checks passed
lighthouse
Details
setup
Details
compile
Details
dist
Details
lint
Details
node
Details
lib
Details
es
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 222 new files uploaded
Details
DEP All dependencies are resolved
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
bundlesize Total bundle size is 411.55KB/430KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
codecov/patch 100% of diff hit (target 97.47%)
Details
codecov/project 97.47% (+0%) compared to 7033a27
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@afc163 afc163 deleted the fix-cascader-search branch Jan 7, 2020
afc163 added a commit that referenced this pull request Jan 8, 2020
and label/value have same field name

close #20619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.