Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tree switcher icon #20753

Merged
merged 1 commit into from Jan 8, 2020
Merged

fix: Tree switcher icon #20753

merged 1 commit into from Jan 8, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jan 8, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #20511

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Tree switcherIcon shown in leaf node problem.
🇨🇳 Chinese 修复 Tree switcherIcon 在叶子节点上展示的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 requested a review from zombieJ as a code owner Jan 8, 2020
@auto-add-label auto-add-label bot added the Fix label Jan 8, 2020
Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@afc163 afc163 changed the title Fix: Tree switcher icon fix: Tree switcher icon Jan 8, 2020
@auto-add-label auto-add-label bot added bug and removed Fix labels Jan 8, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8c62f45f7409036d780ba7389b2b8671409c5255:

Sandbox Source
antd reproduction template Configuration

@netlify
Copy link

netlify bot commented Jan 8, 2020

Deploy preview for ant-design ready!

Built with commit b338b84

https://deploy-preview-20753--ant-design.netlify.com

@afc163 afc163 removed the bug label Jan 8, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b338b84:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #20753 into 3.x-stable will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           3.x-stable   #20753   +/-   ##
===========================================
  Coverage       97.81%   97.81%           
===========================================
  Files             286      286           
  Lines            7749     7749           
  Branches         2172     2138   -34     
===========================================
  Hits             7580     7580           
  Misses            169      169
Impacted Files Coverage Δ
components/tree/Tree.tsx 96.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2753ce9...b338b84. Read the comment docs.

@afc163 afc163 merged commit 6e4fa95 into 3.x-stable Jan 8, 2020
36 checks passed
@afc163 afc163 deleted the fix-tree-switcherIcon branch Jan 8, 2020
@yoyo837 yoyo837 added the 3.x 3.x stable issue or bug fix, PR should be cherry-pick to master label Jan 8, 2020
LukerSpringtree pushed a commit to LukerSpringtree/ant-design that referenced this issue Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x 3.x stable issue or bug fix, PR should be cherry-pick to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants