Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tree switcher icon #20753

Merged
merged 1 commit into from Jan 8, 2020
Merged

fix: Tree switcher icon #20753

merged 1 commit into from Jan 8, 2020

Conversation

@afc163
Copy link
Member

afc163 commented Jan 8, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #20511

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Tree switcherIcon shown in leaf node problem.
🇨🇳 Chinese 修复 Tree switcherIcon 在叶子节点上展示的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@afc163 afc163 requested a review from zombieJ as a code owner Jan 8, 2020
@auto-add-label auto-add-label bot added the Fix label Jan 8, 2020
@pr-triage pr-triage bot added the PR: unreviewed label Jan 8, 2020
Copy link

tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@afc163 afc163 changed the title Fix: Tree switcher icon fix: Tree switcher icon Jan 8, 2020
@auto-add-label auto-add-label bot added bug and removed Fix labels Jan 8, 2020
@afc163 afc163 force-pushed the fix-tree-switcherIcon branch from 8c62f45 to b338b84 Jan 8, 2020
@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Jan 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8c62f45:

Sandbox Source
antd reproduction template Configuration
@netlify

This comment has been minimized.

Copy link

netlify bot commented Jan 8, 2020

Deploy preview for ant-design ready!

Built with commit b338b84

https://deploy-preview-20753--ant-design.netlify.com

@afc163 afc163 removed the bug label Jan 8, 2020
@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Jan 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b338b84:

Sandbox Source
antd reproduction template Configuration
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #20753 into 3.x-stable will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           3.x-stable   #20753   +/-   ##
===========================================
  Coverage       97.81%   97.81%           
===========================================
  Files             286      286           
  Lines            7749     7749           
  Branches         2172     2138   -34     
===========================================
  Hits             7580     7580           
  Misses            169      169
Impacted Files Coverage Δ
components/tree/Tree.tsx 96.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2753ce9...b338b84. Read the comment docs.

@afc163 afc163 merged commit 6e4fa95 into 3.x-stable Jan 8, 2020
36 checks passed
36 checks passed
lighthouse
Details
setup
Details
compile
Details
dist
Details
lint
Details
node
Details
lib
Details
es
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
bundlesize Total bundle size is 592.13KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
codecov/patch 100% of diff hit (target 97.81%)
Details
codecov/project 97.81% (+0%) compared to 2753ce9
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@afc163 afc163 deleted the fix-tree-switcherIcon branch Jan 8, 2020
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jan 8, 2020
afc163 added a commit that referenced this pull request Jan 8, 2020
afc163 added a commit that referenced this pull request Jan 8, 2020
afc163 added a commit that referenced this pull request Jan 8, 2020
afc163 added a commit that referenced this pull request Jan 8, 2020
close #20511
@yoyo837 yoyo837 added the 3.x label Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.