Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose all Dropdown props of BreadcrumbItem #20763

Merged
merged 1 commit into from Mar 2, 2020
Merged

feat: expose all Dropdown props of BreadcrumbItem #20763

merged 1 commit into from Mar 2, 2020

Conversation

paranoidjk
Copy link
Contributor

@paranoidjk paranoidjk commented Jan 8, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Expose all Dropdown props in Breadcrumb.Item
🇨🇳 Chinese 暴露 Breadcrumb.Item 组件的所有 Dropdown 的可配置属性

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/breadcrumb/index.en-US.md
View rendered components/breadcrumb/index.zh-CN.md

@netlify
Copy link

@netlify netlify bot commented Jan 8, 2020

Deploy preview for ant-design ready!

Built with commit b7fdcd8

https://deploy-preview-20763--ant-design.netlify.com

@afc163
Copy link
Member

@afc163 afc163 commented Jan 8, 2020

需求是什么?

@zombieJ zombieJ changed the base branch from master to feature Jan 8, 2020
@zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 8, 2020

云凤蝶需要控制面包屑下拉状态。

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b7fdcd8:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jan 8, 2020

Codecov Report

Merging #20763 into feature will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #20763   +/-   ##
========================================
  Coverage    97.46%   97.46%           
========================================
  Files          296      296           
  Lines         6877     6877           
  Branches      1865     1901   +36     
========================================
  Hits          6703     6703           
  Misses         174      174
Impacted Files Coverage Δ
components/breadcrumb/BreadcrumbItem.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ebaa7e...b7fdcd8. Read the comment docs.

@afc163
Copy link
Member

@afc163 afc163 commented Jan 8, 2020

云凤蝶没升 antd,加了短期内也用不上。

@paranoidjk
Copy link
Contributor Author

@paranoidjk paranoidjk commented Jan 8, 2020

@afc163 没升级是啥意思?master 已经是 V4 了吗?那我可以往 V3 pick 吗?

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Jan 9, 2020

master 已经 v4。

@afc163 afc163 removed the enhancement label Jan 9, 2020
@zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 9, 2020

感觉还是应该弄到 v4 来,v3 理论上不接受新的 feature 了。

afc163
afc163 approved these changes Mar 2, 2020
@afc163 afc163 merged commit 84173d9 into feature Mar 2, 2020
32 checks passed
@afc163 afc163 deleted the bread-visible branch Mar 2, 2020
@pr-triage pr-triage bot added the PR: merged label Mar 2, 2020
@zombieJ zombieJ mentioned this pull request Mar 29, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants