Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0 Form scrollToField: Pass options to form scrollToField #20774

Merged
merged 3 commits into from Jan 14, 2020
Merged

4.0 Form scrollToField: Pass options to form scrollToField #20774

merged 3 commits into from Jan 14, 2020

Conversation

hans-lizihan
Copy link
Contributor

@hans-lizihan hans-lizihan commented Jan 8, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

if there were fixed header, scrollToField is scrolling to the wrong position.

according to the thread here stipsan/scroll-into-view-if-needed#126 (comment), passing in options to scroll-into-view-if-needded package could potentially solve the problem.

📝 Changelog

Language Changelog
🇺🇸 English pass form.scrollToField's second parameter to scroll-to-field-if-needed package
🇨🇳 Chinese 允许form.scrollToField的第二个参数传入scroll-to-field-if-needed

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/form/index.en-US.md
View rendered components/form/index.zh-CN.md

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

@netlify netlify bot commented Jan 8, 2020

Deploy preview for ant-design ready!

Built with commit 73d8125

https://deploy-preview-20774--ant-design.netlify.com

@codecov
Copy link

@codecov codecov bot commented Jan 9, 2020

Codecov Report

Merging #20774 into feature will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #20774   +/-   ##
========================================
  Coverage    97.47%   97.47%           
========================================
  Files          296      296           
  Lines         6899     6899           
  Branches      1868     1915   +47     
========================================
  Hits          6725     6725           
  Misses         174      174
Impacted Files Coverage Δ
components/form/util.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e320904...73d8125. Read the comment docs.

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 73d8125:

Sandbox Source
antd reproduction template Configuration

@hans-lizihan hans-lizihan changed the title Pass options to form scrollToField 4.0 Form scrollToField: Pass options to form scrollToField Jan 9, 2020
@zombieJ zombieJ changed the base branch from master to feature Jan 10, 2020
@zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 10, 2020

Move into feature branch. Could you help to rebase your code? Thanks

@hans-lizihan
Copy link
Contributor Author

@hans-lizihan hans-lizihan commented Jan 10, 2020

@zombieJ rebased~

components/form/index.zh-CN.md Outdated Show resolved Hide resolved
@zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 14, 2020

CI failed. Rebase feature please.

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jan 14, 2020

Preview deploy to https://preview-20774-ant-design.surge.sh

components/form/index.en-US.md Outdated Show resolved Hide resolved
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jan 14, 2020

Preview deploy to https://preview-20774-ant-design.surge.sh

@zombieJ zombieJ merged commit 1fb7407 into ant-design:feature Jan 14, 2020
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants