-
-
Notifications
You must be signed in to change notification settings - Fork 50.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.0 Form scrollToField: Pass options to form scrollToField #20774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
Deploy preview for ant-design ready! Built with commit 73d8125 |
Codecov Report
@@ Coverage Diff @@
## feature #20774 +/- ##
========================================
Coverage 97.47% 97.47%
========================================
Files 296 296
Lines 6899 6899
Branches 1868 1915 +47
========================================
Hits 6725 6725
Misses 174 174
Continue to review full report at Codecov.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 73d8125:
|
Move into |
@zombieJ rebased~ |
CI failed. Rebase feature please. |
Preview deploy to https://preview-20774-ant-design.surge.sh |
Preview deploy to https://preview-20774-ant-design.surge.sh |
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
if there were fixed header,
scrollToField
is scrolling to the wrong position.according to the thread here scroll-into-view/scroll-into-view-if-needed#126 (comment), passing in options to
scroll-into-view-if-needded
package could potentially solve the problem.📝 Changelog
form.scrollToField
's second parameter toscroll-to-field-if-needed
packageform.scrollToField
的第二个参数传入scroll-to-field-if-needed
包☑️ Self Check before Merge
View rendered components/form/index.en-US.md
View rendered components/form/index.zh-CN.md