Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复 Carousel 组件 left/right 模式下卡片轮播方向 #20781

Merged
merged 4 commits into from Jan 9, 2020
Merged

fix: 修复 Carousel 组件 left/right 模式下卡片轮播方向 #20781

merged 4 commits into from Jan 9, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Jan 9, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #20780

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fixed Carousel card carousel orientation in left / right mode
🇨🇳 Chinese 修复 Carousel 组件 left/right 模式下卡片轮播方向

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

@netlify netlify bot commented Jan 9, 2020

Deploy preview for ant-design ready!

Built with commit 31b2028

https://deploy-preview-20781--ant-design.netlify.com

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 31b2028:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jan 9, 2020

Codecov Report

Merging #20781 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20781   +/-   ##
=======================================
  Coverage   97.46%   97.46%           
=======================================
  Files         296      296           
  Lines        6877     6877           
  Branches     1865     1911   +46     
=======================================
  Hits         6703     6703           
  Misses        174      174
Impacted Files Coverage Δ
components/carousel/index.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b9a16...31b2028. Read the comment docs.

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Jan 9, 2020

Please add some test case for this patch.

@xrkffgg
Copy link
Member Author

@xrkffgg xrkffgg commented Jan 9, 2020

@yoyo837 不知道为啥 4.0-rc 把关于 vertical 这部分都给去了,但确实是影响了原有的效果

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Jan 9, 2020

#20547 @afc163

@afc163 afc163 merged commit 0800063 into ant-design:master Jan 9, 2020
20 of 21 checks passed
@xrkffgg xrkffgg deleted the k-test branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants