chore: Not block input when Input value is undefined
#20783
Conversation
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e59301f:
|
|
Deploy preview for ant-design ready! Built with commit e59301f |
|
Select and Input controlled mode have breaking change in v4 that we should report it in ChangeLog. |
| }; | ||
| static getDerivedStateFromProps(nextProps: InputProps, { prevValue }: InputState) { | ||
| const newState: Partial<InputState> = { prevValue: nextProps.value }; | ||
| if (nextProps.value !== undefined || prevValue !== nextProps.value) { |
There was a problem hiding this comment.
我们的 Table customize 例子里重置是把 filter value 数组从 [e.target.value] 改成 []，它会变成 undefined 成为非受控模式。这会 break 掉原本的行为。所以特地加一个判断，如果是值变化，总是触发一下。
There was a problem hiding this comment.
这个 break change 在用户代码里的细节很多，我们会遇到的话用户也会，考虑一下是不是可以不 break。
There was a problem hiding this comment.
现在唯一的 breaking change 就是 undefined 为非受控，其他的情况切换都是受控。考虑的情况应该是比较全面的了。
There was a problem hiding this comment.
👌，至少 undefined 时受控改不受控，不会出现用户无法输入的问题，这个可能引发的问题还是比较小的。
Codecov Report
@@ Coverage Diff @@
## master #20783 +/- ##
==========================================
+ Coverage 97.46% 97.47% +<.01%
==========================================
Files 296 296
Lines 6877 6878 +1
Branches 1912 1865 -47
==========================================
+ Hits 6703 6704 +1
Misses 174 174
Continue to review full report at Codecov.
|
🤔 This is a ...
🔗 Related issue link
fix #20776
💡 Background and solution
📝 Changelog
undefined.☑️ Self Check before Merge