Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move table-bg less variable into table background instead of td #20794

merged 1 commit into from Jan 9, 2020


Copy link

@zombieJ zombieJ commented Jan 9, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

fix #20756

馃挕 Background and solution

Since we already provides @table-bg background color. Maybe not good to make it as transparent. Move into table bg instead.

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Fix Table background color css priority to high to override user customize style.
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

netlify bot commented Jan 9, 2020

Deploy preview for ant-design ready!

Built with commit 9e87bf8

Copy link

codesandbox-ci bot commented Jan 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9e87bf8:

Sandbox Source
antd reproduction template Configuration

Copy link

codecov bot commented Jan 9, 2020

Codecov Report

鉂 No coverage uploaded for pull request base (master@935a984). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #20794   +/-   ##
  Coverage          ?   97.47%           
  Files             ?      296           
  Lines             ?     6878           
  Branches          ?     1911           
  Hits              ?     6704           
  Misses            ?      174           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 935a984...9e87bf8. Read the comment docs.

@zombieJ zombieJ merged commit 1bea19b into master Jan 9, 2020
@zombieJ zombieJ deleted the table-bg branch January 9, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Table's column className and rowClassName don't work on antd 4.0 RC
1 participant