Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🆕 Add buttonsRender to Dropdown #20815

Merged
merged 4 commits into from Jan 13, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jan 10, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

none

💡 Background and solution

Dropdown.Button 中不支持 Tooltip 吗?要搞这样一个神奇的效果,鼠标附上编辑,给出可以用快捷键 e 直接进入编辑模式,类似 confluence 的

image

image

📝 Changelog

Language Changelog
🇺🇸 English Dropdown supports buttonsRender to custom button.
🇨🇳 Chinese Dropdown 新增 buttonsRender 用于定制按钮,如给左侧按钮增加 Tooltip。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/dropdown/demo/dropdown-button.md
View rendered components/dropdown/index.en-US.md
View rendered components/dropdown/index.zh-CN.md

@netlify
Copy link

@netlify netlify bot commented Jan 10, 2020

Deploy preview for ant-design ready!

Built with commit fd2af1c

https://deploy-preview-20815--ant-design.netlify.com

@codecov
Copy link

@codecov codecov bot commented Jan 10, 2020

Codecov Report

Merging #20815 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20815      +/-   ##
==========================================
+ Coverage   97.47%   97.47%   +<.01%     
==========================================
  Files         296      296              
  Lines        6880     6884       +4     
  Branches     1901     1911      +10     
==========================================
+ Hits         6706     6710       +4     
  Misses        174      174
Impacted Files Coverage Δ
components/dropdown/dropdown-button.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0eaebc...fd2af1c. Read the comment docs.

@afc163 afc163 merged commit 2dc7b3f into master Jan 13, 2020
30 of 31 checks passed
@afc163 afc163 deleted the feat-dropdown-button-tooltips branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant