Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Min-Width Style Variables for Switch Component #20829

Merged
merged 3 commits into from Jan 11, 2020

Conversation

abdih
Copy link
Contributor

@abdih abdih commented Jan 10, 2020

Implementation of feature request from @LuisRodriguezLD

馃 This is a ...

  • New feature

馃敆 Related issue link

close #20826

#20826

馃挕 Background and solution

Use less variable instead of a fixed constant for min-width of Switch component.

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Add variables to themes > default.less
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

@netlify netlify bot commented Jan 10, 2020

Deploy preview for ant-design ready!

Built with commit 8c978aa

https://deploy-preview-20829--ant-design.netlify.com

@abdih abdih mentioned this pull request Jan 10, 2020
1 task
@abdih abdih changed the title Use Less Variables for Min-Width of Switch Component Add Min-Width Style Variables for Switch Component Jan 10, 2020
@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 10, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ea127468d2591d90ec2a81f6fefb0c92979c52aa:

Sandbox Source
antd reproduction template Configuration

@abdih abdih changed the title Add Min-Width Style Variables for Switch Component Feat: Add Min-Width Style Variables for Switch Component Jan 10, 2020
@auto-add-label auto-add-label bot added the Feat label Jan 10, 2020
@abdih abdih changed the title Feat: Add Min-Width Style Variables for Switch Component Feat -- Add Min-Width Style Variables for Switch Component Jan 10, 2020
@abdih abdih changed the title Feat -- Add Min-Width Style Variables for Switch Component feat: Add Min-Width Style Variables for Switch Component Jan 10, 2020
@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 10, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit de54d26ecc60b5bc1c1a4d86b5680e5c2213fffd:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 10, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8c978aa:

Sandbox Source
antd reproduction template Configuration

@abdih abdih changed the base branch from master to feature Jan 10, 2020
@codecov
Copy link

@codecov codecov bot commented Jan 11, 2020

Codecov Report

Merging #20829 into feature will decrease coverage by 0.34%.
The diff coverage is 98.84%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #20829      +/-   ##
===========================================
- Coverage    97.81%   97.47%   -0.35%     
===========================================
  Files          286      296      +10     
  Lines         7737     6880     -857     
  Branches      2176     1911     -265     
===========================================
- Hits          7568     6706     -862     
- Misses         169      174       +5
Impacted Files Coverage 螖
components/descriptions/index.tsx 98.92% <酶> (酶) 猬嗭笍
components/config-provider/index.tsx 91.66% <酶> (-3.34%) 猬囷笍
components/date-picker/locale/fa_IR.tsx 100% <酶> (酶) 猬嗭笍
components/anchor/AnchorLink.tsx 100% <酶> (酶) 猬嗭笍
components/date-picker/locale/mk_MK.tsx 100% <酶> (酶) 猬嗭笍
components/date-picker/locale/hu_HU.tsx 100% <酶> (酶) 猬嗭笍
components/date-picker/locale/mn_MN.tsx 100% <酶> (酶) 猬嗭笍
components/date-picker/locale/sl_SI.tsx 100% <酶> (酶) 猬嗭笍
components/date-picker/locale/pt_PT.tsx 100% <酶> (酶) 猬嗭笍
components/date-picker/locale/et_EE.tsx 100% <酶> (酶) 猬嗭笍
... and 203 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 74082de...8c978aa. Read the comment docs.

afc163
afc163 approved these changes Jan 11, 2020
@zombieJ zombieJ merged commit d70637e into ant-design:feature Jan 11, 2020
20 checks passed
@pr-triage pr-triage bot added the PR: merged label Jan 11, 2020
@abdih abdih deleted the feature branch Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants