Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Form.Item): label text align not correct when media less than xs and span not 24 #20836

Merged
merged 1 commit into from Jan 13, 2020
Merged

fix(Form.Item): label text align not correct when media less than xs and span not 24 #20836

merged 1 commit into from Jan 13, 2020

Conversation

shaodahong
Copy link
Member

@shaodahong shaodahong commented Jan 11, 2020

…and span not 24

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Fixes #20834

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese 修复 Form.Item label 在屏幕小于 xs 并且 span 不是 24 的时候对齐不正确

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

@netlify netlify bot commented Jan 11, 2020

Deploy preview for ant-design ready!

Built with commit 831073a

https://deploy-preview-20836--ant-design.netlify.com

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 11, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 831073a:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jan 11, 2020

Codecov Report

Merging #20836 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20836   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files         296      296           
  Lines        6880     6880           
  Branches     1911     1901   -10     
=======================================
  Hits         6706     6706           
  Misses        174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a1c510...831073a. Read the comment docs.

@shaodahong shaodahong mentioned this pull request Jan 11, 2020
17 tasks
@shaodahong
Copy link
Member Author

@shaodahong shaodahong commented Jan 11, 2020

@zombieJ Cause by #17327 (comment), Please help me review.

@shaodahong shaodahong requested a review from zombieJ Jan 11, 2020
@zombieJ zombieJ merged commit 5a81182 into ant-design:master Jan 13, 2020
22 checks passed
@shaodahong shaodahong deleted the fix-form-xs-label-align branch Jan 13, 2020
@zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 4, 2020

Why we should patch @ant-design/compatible in v4 branch?

This break the align:
截屏2020-02-04下午1 46 59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants