Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table onChange return cached data #20858

merged 1 commit into from Jan 13, 2020

fix: Table onChange return cached data #20858

merged 1 commit into from Jan 13, 2020


Copy link

@zombieJ zombieJ commented Jan 13, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #20854

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table onChange return cached fresh sorter & filter state.
🇨🇳 Chinese 修复 Table onChange 返回缓存排序、过滤状态的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

Copy link

@netlify netlify bot commented Jan 13, 2020

Deploy preview for ant-design ready!

Built with commit 24dabba

Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 13, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 24dabba:

Sandbox Source
antd reproduction template Configuration

Copy link

@codecov codecov bot commented Jan 13, 2020

Codecov Report

Merging #20858 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20858      +/-   ##
- Coverage   97.47%   97.47%   -0.01%     
  Files         296      296              
  Lines        6884     6883       -1     
  Branches     1912     1865      -47     
- Hits         6710     6709       -1     
  Misses        174      174
Impacted Files Coverage Δ
components/table/hooks/useFilter/index.tsx 100% <100%> (ø) ⬆️
components/table/hooks/useSorter.tsx 90.22% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc7b3f...24dabba. Read the comment docs.

@zombieJ zombieJ merged commit f470f3e into master Jan 13, 2020
32 checks passed
@zombieJ zombieJ deleted the fix-table-change branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

1 participant