Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select placeholder style issue #20883

Merged
merged 2 commits into from Jan 14, 2020
Merged

fix: Select placeholder style issue #20883

merged 2 commits into from Jan 14, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 14, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #20828

💡 Background and solution

Kapture 2020-01-14 at 11 31 56

📝 Changelog

Language Changelog
🇺🇸 English Fix Select placeholder display not correct when in narrow position.
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Jan 14, 2020

Deploy preview for ant-design ready!

Built with commit 31acd00

https://deploy-preview-20883--ant-design.netlify.com

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 590a644:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 31acd00:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #20883 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20883   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files         296      296           
  Lines        6883     6883           
  Branches     1865     1912   +47     
=======================================
  Hits         6709     6709           
  Misses        174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c092df...31acd00. Read the comment docs.

@zombieJ zombieJ merged commit 9d7edcd into master Jan 14, 2020
@zombieJ zombieJ deleted the fix-select-placeholder branch January 14, 2020 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select placeholder position not correct when set to mode multiple on form with inline layout
1 participant