Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tooltip hidden when title is 0 #20894

Merged
merged 1 commit into from Jan 14, 2020
Merged

fix: Tooltip hidden when title is 0 #20894

merged 1 commit into from Jan 14, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jan 14, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #20891

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Tooltip hidden when title is 0.
🇨🇳 Chinese 修复 Tooltip title0 时没有显示问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

@netlify netlify bot commented Jan 14, 2020

Deploy preview for ant-design ready!

Built with commit 3fafca8

https://deploy-preview-20894--ant-design.netlify.com

@codesandbox
Copy link

@codesandbox codesandbox bot commented Jan 14, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3fafca8:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jan 14, 2020

Codecov Report

Merging #20894 into 3.x-stable will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           3.x-stable   #20894      +/-   ##
==============================================
+ Coverage       97.81%   97.82%   +<.01%     
==============================================
  Files             286      286              
  Lines            7749     7753       +4     
  Branches         2183     2184       +1     
==============================================
+ Hits             7580     7584       +4     
  Misses            169      169
Impacted Files Coverage Δ
components/tooltip/index.tsx 96.77% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db4bec9...3fafca8. Read the comment docs.

@afc163 afc163 merged commit b112378 into 3.x-stable Jan 14, 2020
37 checks passed
@afc163 afc163 deleted the fix-tooltip branch Jan 14, 2020
afc163 added a commit that referenced this issue Jan 14, 2020
@afc163 afc163 mentioned this pull request Feb 3, 2020
LukerSpringtree pushed a commit to LukerSpringtree/ant-design that referenced this issue Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant