Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: List actions inconsistent position #20897

Merged
merged 1 commit into from Jan 15, 2020
Merged

fix: List actions inconsistent position #20897

merged 1 commit into from Jan 15, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jan 14, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #20648

💡 Background and solution

总结一下:

  1. 当 List.Item 的 children 里只有一个节点,则始终开启 flex 模式,并使用 justify-content: space-between; 进行两端对齐。
  2. 当 List.Item 的 children 里有多个节点,且一部分是 string,则不开启 flex 模式。右侧节点用 float: right 靠右。

📝 Changelog

Language Changelog
🇺🇸 English Fix List actions inconsistent position.
🇨🇳 Chinese 修复 List actions 位置不在右边的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

@netlify netlify bot commented Jan 14, 2020

Deploy preview for ant-design ready!

Built with commit a7f5a85

https://deploy-preview-20897--ant-design.netlify.com

@codesandbox
Copy link

@codesandbox codesandbox bot commented Jan 14, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a7f5a85:

Sandbox Source
antd reproduction template Configuration
antd reproduction template Issue #20648

@codecov
Copy link

@codecov codecov bot commented Jan 14, 2020

Codecov Report

Merging #20897 into 3.x-stable will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           3.x-stable   #20897   +/-   ##
===========================================
  Coverage       97.81%   97.81%           
===========================================
  Files             286      286           
  Lines            7749     7749           
  Branches         2183     2139   -44     
===========================================
  Hits             7580     7580           
  Misses            169      169
Impacted Files Coverage Δ
components/list/Item.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db4bec9...a7f5a85. Read the comment docs.

@afc163 afc163 merged commit a96a95c into 3.x-stable Jan 15, 2020
36 checks passed
@afc163 afc163 deleted the fix-list-action branch Jan 15, 2020
afc163 added a commit that referenced this issue Jan 15, 2020
LukerSpringtree pushed a commit to LukerSpringtree/ant-design that referenced this issue Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant