Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tooltip doesn't disappear on disabled Dropdown.Button #20960

Merged
merged 1 commit into from Jan 17, 2020

Conversation

cjmafei
Copy link
Contributor

@cjmafei cjmafei commented Jan 17, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Tooltip doesn't disappear on disabled Dropdown.Button
🇨🇳 Chinese Tooltip 没有消失在disabled 的 Dropdown.Button

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jan 17, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 17, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 889d44e:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jan 17, 2020

Codecov Report

Merging #20960 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20960      +/-   ##
==========================================
+ Coverage   97.47%   97.47%   +<.01%     
==========================================
  Files         296      296              
  Lines        6901     6902       +1     
  Branches     1915     1905      -10     
==========================================
+ Hits         6727     6728       +1     
  Misses        174      174
Impacted Files Coverage Δ
components/dropdown/dropdown-button.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fbc2d3...889d44e. Read the comment docs.

@cjmafei cjmafei requested a review from zombieJ Jan 17, 2020
@zombieJ zombieJ merged commit 32e8015 into ant-design:master Jan 17, 2020
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants