Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Form.Item keep render even it's not a Field #20963

Merged
merged 4 commits into from Jan 17, 2020
Merged

fix: Form.Item keep render even it's not a Field #20963

merged 4 commits into from Jan 17, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 17, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #20948

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Form.Item will trigger re-render even if it's not a real Field.
🇨🇳 Chinese 修复 Form.Item 即便不是一个真正的 Field 也会触发重新渲染的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@auto-add-label auto-add-label bot added the bug label Jan 17, 2020
Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jan 17, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 17, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6a5a439:

Sandbox Source
antd reproduction template Configuration
Form.Item-Form.Item Issue #20948

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 17, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7a4ae5f:

Sandbox Source
antd reproduction template Configuration
Form.Item-Form.Item Issue #20948

@codecov
Copy link

@codecov codecov bot commented Jan 17, 2020

Codecov Report

Merging #20963 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20963      +/-   ##
==========================================
+ Coverage   97.47%   97.48%   +<.01%     
==========================================
  Files         296      296              
  Lines        6901     6908       +7     
  Branches     1869     1871       +2     
==========================================
+ Hits         6727     6734       +7     
  Misses        174      174
Impacted Files Coverage Δ
components/form/FormItemLabel.tsx 100% <100%> (ø) ⬆️
components/form/FormItemInput.tsx 93.33% <100%> (+0.22%) ⬆️
components/form/FormItem.tsx 98.96% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0937ee5...7a4ae5f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants