Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove labelInValue in AutoComplete props #20967

Merged
merged 1 commit into from Jan 17, 2020
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 17, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

ref #20955

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Remove labelInValue typescript define with AutoComplete since it's useless.
🇨🇳 Chinese 移除掉 AutoComplete 中无用的 labelInValue 定义。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jan 17, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 17, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c1bf289:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jan 17, 2020

Codecov Report

Merging #20967 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20967   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         296      296           
  Lines        6909     6909           
  Branches     1871     1918   +47     
=======================================
  Hits         6735     6735           
  Misses        174      174
Impacted Files Coverage Δ
components/auto-complete/index.tsx 95% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32e8015...c1bf289. Read the comment docs.

@zombieJ zombieJ merged commit 7f1f08b into master Jan 17, 2020
28 checks passed
@zombieJ zombieJ deleted the auto-complete-ts branch Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants