Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table selectAll should not checked when all the checkbox is disa… #20968

Merged
merged 1 commit into from Jan 17, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 17, 2020

…bled

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #20933

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table select all checkbox is checked when all the checkbox is disabled.
🇨🇳 Chinese 修复 Table 全选在所有选项为禁用时为勾选状态的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jan 17, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 17, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 61bfcbf:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jan 17, 2020

Codecov Report

Merging #20968 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20968   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         296      296           
  Lines        6909     6909           
  Branches     1871     1916   +45     
=======================================
  Hits         6735     6735           
  Misses        174      174
Impacted Files Coverage Δ
components/table/hooks/useSelection.tsx 98.83% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f1f08b...61bfcbf. Read the comment docs.

@zombieJ zombieJ merged commit ddfce71 into master Jan 17, 2020
28 checks passed
@zombieJ zombieJ deleted the table-select-all branch Jan 17, 2020
@fbambi
Copy link

@fbambi fbambi commented May 7, 2021

@zombieJ if you set all row checked, and then disabled all, the head checkbox will not be checked.
I think this PR make this.
Can you fix this?

image
https://codesandbox.io/s/xuanzehecaozuo-antd4154-forked-2uiov?file=/index.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants