Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Drawer组件添加 footerStyle 控制台报错 #20983

Merged
merged 5 commits into from Jan 17, 2020

Conversation

XianZhengquan
Copy link
Contributor

@XianZhengquan XianZhengquan commented Jan 17, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #20978

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English -
🇨🇳 Chinese 修复 Drawer组件添加footerStyle属性后控制台报错

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

`Drawer`组件 添加 footerStyle 属性后,把该属性挂载到了 div 上,导致控制台报错
fix : `.ant-drawer-header` height 属性不生效
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jan 17, 2020

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Jan 17, 2020

写一下 Changelog

@XianZhengquan
Copy link
Contributor Author

@XianZhengquan XianZhengquan commented Jan 17, 2020

在哪里写

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Jan 17, 2020

image

@XianZhengquan
Copy link
Contributor Author

@XianZhengquan XianZhengquan commented Jan 17, 2020

加上了

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 17, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b72fecb:

Sandbox Source
antd reproduction template Configuration
sharp-water-lmy6o Issue #20978

@codecov
Copy link

@codecov codecov bot commented Jan 17, 2020

Codecov Report

Merging #20983 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20983   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         296      296           
  Lines        6909     6909           
  Branches     1906     1870   -36     
=======================================
  Hits         6735     6735           
  Misses        174      174
Impacted Files Coverage Δ
components/drawer/index.tsx 98.78% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56840ae...b72fecb. Read the comment docs.

components/drawer/style/drawer.less Outdated Show resolved Hide resolved
feat : Drawer组件DOM属性 排除 footer 和 locale
revert:  flex: 1; =>  flex-grow: 1;
@XianZhengquan
Copy link
Contributor Author

@XianZhengquan XianZhengquan commented Jan 17, 2020

改好了

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Jan 17, 2020

贡献指南

Run npm test -- -u to update the jest snapshots and commit these changes as well (if there are any updates).

@XianZhengquan
Copy link
Contributor Author

@XianZhengquan XianZhengquan commented Jan 17, 2020

贡献指南

Run npm test -- -u to update the jest snapshots and commit these changes as well (if there are any updates).

我现在是运行这个,然后再提交嘛

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Jan 17, 2020

贡献指南
Run npm test -- -u to update the jest snapshots and commit these changes as well (if there are any updates).

我现在是运行这个,然后再提交嘛

运行完,把变更push上来。

@XianZhengquan
Copy link
Contributor Author

@XianZhengquan XianZhengquan commented Jan 17, 2020

贡献指南
Run npm test -- -u to update the jest snapshots and commit these changes as well (if there are any updates).

我现在是运行这个,然后再提交嘛

运行完,把变更push上来。

好的

@XianZhengquan
Copy link
Contributor Author

@XianZhengquan XianZhengquan commented Jan 17, 2020

终于跑完了,push 了

@afc163 afc163 merged commit 219cae3 into ant-design:master Jan 17, 2020
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants