Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (Timeline): add @timeline-item-padding variable #21013

Merged

Conversation

MrHeer
Copy link
Contributor

@MrHeer MrHeer commented Jan 19, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

馃挕 Background and solution

close #20953

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English add @timeline-item-padding variable
馃嚚馃嚦 Chinese 鏂板 @timeline-item-padding variable

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@MrHeer MrHeer changed the title 馃拕 (Timeline): add @timeline-item-padding variable feat: (Timeline): add @timeline-item-padding variable Jan 19, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jan 19, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 19, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a37c78a:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jan 19, 2020

Codecov Report

Merging #21013 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21013   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         296      296           
  Lines        6909     6909           
  Branches     1870     1916   +46     
=======================================
  Hits         6735     6735           
  Misses        174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 2584635...a37c78a. Read the comment docs.

@yoyo837 yoyo837 merged commit 6b3b6aa into ant-design:master Jan 19, 2020
1 of 7 checks passed
@MrHeer MrHeer deleted the add-timeline-item-padding-variable branch Jan 19, 2020
@@ -17,7 +17,7 @@
&-item {
position: relative;
margin: 0;
padding: 0 0 20px;
padding: @timeline-item-padding;
Copy link
Member

@afc163 afc163 Jan 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timeline-item-padding-bottom: 20px; is better.

@afc163
Copy link
Member

afc163 commented Jan 19, 2020

I don't think this will resolve #20953, @Ta2Rim do not need last padding bottom only.

yoyo837 added a commit that referenced this pull request Jan 19, 2020
@yoyo837 yoyo837 mentioned this pull request Jan 19, 2020
14 tasks
zombieJ pushed a commit that referenced this pull request Jan 20, 2020
* Revert "馃拕 (Timeline): add @timeline-item-padding variable (#21013)"

This reverts commit 6b3b6aa.

* add @timeline-item-padding-bottom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4.x] Suggestion of timeline component styling
4 participants