feat: (Timeline): add @timeline-item-padding variable #21013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrHeer
changed the title
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a37c78a:
|
Codecov Report
@@ Coverage Diff @@
## master #21013 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 296 296
Lines 6909 6909
Branches 1870 1916 +46
=======================================
Hits 6735 6735
Misses 174 174Continue to review full report at Codecov.
|
yoyo837
approved these changes
Jan 19, 2020
afc163
reviewed
Jan 19, 2020
| @@ -17,7 +17,7 @@ | |||
| &-item { | |||
| position: relative; | |||
| margin: 0; | |||
| padding: 0 0 20px; | |||
| padding: @timeline-item-padding; | |||
There was a problem hiding this comment.
@timeline-item-padding-bottom: 20px; is better.
|
I don't think this will resolve #20953, @Ta2Rim do not need last padding bottom only. |
yoyo837
added a commit
that referenced
this pull request
Jan 19, 2020
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
close #20953