Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Form.Item ignore help = '' #21026

Merged
merged 2 commits into from Jan 20, 2020
Merged

fix: Form.Item ignore help = '' #21026

merged 2 commits into from Jan 20, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 20, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

ref: ant-design/pro-blocks#164

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Form.Item ignore help="" issue.
🇨🇳 Chinese 修复 Form.Item 不处理 help="" 的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jan 20, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 20, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 728b107:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jan 20, 2020

Codecov Report

Merging #21026 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21026   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         296      296           
  Lines        6910     6910           
  Branches     1917     1917           
=======================================
  Hits         6736     6736           
  Misses        174      174
Impacted Files Coverage Δ
components/form/FormItem.tsx 98.96% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aee6d6...728b107. Read the comment docs.

@zombieJ zombieJ merged commit bfcd00a into master Jan 20, 2020
28 checks passed
@zombieJ zombieJ deleted the help-form branch Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants