Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix TS define of FormItem #21067

Merged
merged 1 commit into from Jan 22, 2020
Merged

chore: Fix TS define of FormItem #21067

merged 1 commit into from Jan 22, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 22, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

ref #21065

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Fix Form.Item return type define.
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jan 22, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 22, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 247dfc5:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jan 22, 2020

Codecov Report

Merging #21067 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21067   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         296      296           
  Lines        6911     6911           
  Branches     1918     1907   -11     
=======================================
  Hits         6737     6737           
  Misses        174      174
Impacted Files Coverage 螖
components/form/FormItem.tsx 98.96% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 1fc5572...247dfc5. Read the comment docs.

@zombieJ zombieJ merged commit ee6f63f into master Jan 22, 2020
28 checks passed
@zombieJ zombieJ deleted the form-ts branch Jan 22, 2020
@AO19
Copy link

@AO19 AO19 commented Jan 22, 2020

Update ant-design/icons to 4.0.0-rc.0 , most of the examples and packages are still at vesion 2...

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Jan 22, 2020

What's means of version 2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants