Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix wrong event type of AntTreeNodeMouseEvent #21102

Merged
merged 1 commit into from Jan 24, 2020

Conversation

jirkalhotka
Copy link
Contributor

@jirkalhotka jirkalhotka commented Jan 24, 2020

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

πŸ”— Related issue link

πŸ’‘ Background and solution

This fixes #16618 – the fix suggested in the issue which was implemented is wrong, the event type is actually a React.DragEvent

πŸ“ Changelog

Language Changelog
πŸ‡ΊπŸ‡Έ English
πŸ‡¨πŸ‡³ Chinese

β˜‘οΈ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@jirkalhotka jirkalhotka requested a review from zombieJ as a code owner Jan 24, 2020
@jirkalhotka jirkalhotka changed the title Fix wrong event type of AntTreeNodeMouseEvent fix: Fix wrong event type of AntTreeNodeMouseEvent Jan 24, 2020
@auto-add-label auto-add-label bot added the bug label Jan 24, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jan 24, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 24, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ec8791b:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jan 24, 2020

Codecov Report

Merging #21102 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21102   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         296      296           
  Lines        6911     6911           
  Branches     1907     1907           
=======================================
  Hits         6737     6737           
  Misses        174      174
Impacted Files Coverage Ξ”
components/tree/Tree.tsx 100% <ΓΈ> (ΓΈ) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 1db1e57...ec8791b. Read the comment docs.

@afc163 afc163 merged commit a0fec08 into ant-design:master Jan 24, 2020
18 checks passed
@jirkalhotka jirkalhotka deleted the patch-1 branch Jan 25, 2020
@zombieJ zombieJ mentioned this pull request Jan 27, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants