Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve #20598 remove moment deps in Countdown #21108

Merged
merged 1 commit into from Jan 27, 2020

Conversation

morenyang
Copy link
Contributor

@morenyang morenyang commented Jan 26, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

close #20598

馃挕 Background and solution

Native API is OK, but Typescript doesn't allow new Date(undefined), so use new Date(value as any) to resolve it.

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Use native Date instead of moment to get timestamp in Countdown component.
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jan 26, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 26, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit aa61cfd:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jan 26, 2020

Codecov Report

Merging #21108 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21108      +/-   ##
==========================================
- Coverage   97.48%   97.45%   -0.03%     
==========================================
  Files         296      296              
  Lines        6911     6911              
  Branches     1918     1918              
==========================================
- Hits         6737     6735       -2     
- Misses        174      176       +2
Impacted Files Coverage 螖
components/statistic/Countdown.tsx 100% <100%> (酶) 猬嗭笍
components/statistic/utils.tsx 100% <100%> (酶) 猬嗭笍
components/_util/interopDefault.ts 0% <0%> (-100%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3ee4d82...aa61cfd. Read the comment docs.

@yoyo837 yoyo837 changed the title resolve #20598 remove moment deps in Countdown fix: resolve #20598 remove moment deps in Countdown Jan 26, 2020
@auto-add-label auto-add-label bot added the bug label Jan 26, 2020
@zombieJ zombieJ merged commit 8f5ea54 into ant-design:master Jan 27, 2020
18 checks passed
@zombieJ zombieJ mentioned this pull request Jan 27, 2020
10 tasks
@morenyang morenyang deleted the countdown-remove-moment branch Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants