Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #21134 checkbox can't receive context update from checkbox group #21146

Merged
merged 2 commits into from Jan 31, 2020

Conversation

morenyang
Copy link
Contributor

@morenyang morenyang commented Jan 30, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

close #21134

馃挕 Background and solution

Replace legency context api with React.createContext API and Context.Provider.

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Fix checkbox can't receive context update from checkbox group.
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jan 30, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 30, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e9baa29:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jan 30, 2020

Codecov Report

Merging #21146 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21146      +/-   ##
==========================================
- Coverage   97.45%   97.45%   -0.01%     
==========================================
  Files         296      296              
  Lines        6912     6911       -1     
  Branches     1918     1871      -47     
==========================================
- Hits         6736     6735       -1     
  Misses        176      176
Impacted Files Coverage 螖
components/checkbox/Group.tsx 100% <100%> (酶) 猬嗭笍
components/checkbox/Checkbox.tsx 96.15% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update db99fe7...e9baa29. Read the comment docs.

@afc163
Copy link
Member

@afc163 afc163 commented Jan 30, 2020

Could you add test case?

@morenyang
Copy link
Contributor Author

@morenyang morenyang commented Jan 30, 2020

Could you add test case?

Yes,
use the case in the issue?

@afc163
Copy link
Member

@afc163 afc163 commented Jan 30, 2020

yep

@morenyang morenyang force-pushed the fix-checkbox-group-context-issue branch from d18c78e to e9baa29 Compare Jan 30, 2020
@afc163 afc163 merged commit 048a6e2 into ant-design:master Jan 31, 2020
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants