Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table expandIcon should work #21169

Merged
merged 2 commits into from Feb 1, 2020
Merged

fix: Table expandIcon should work #21169

merged 2 commits into from Feb 1, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 1, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

fix #21154

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Fix Table expandIcon not work when data do not have children.
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Feb 1, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Feb 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0cb24d8:

Sandbox Source
antd reproduction template Configuration
great-williamson-t3ium Issue #21154
intelligent-sunset-lw1bc Issue #21154
naughty-einstein-d8tjy Issue #21154

@codecov
Copy link

@codecov codecov bot commented Feb 1, 2020

Codecov Report

Merging #21169 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21169      +/-   ##
==========================================
+ Coverage   97.45%   97.45%   +<.01%     
==========================================
  Files         296      296              
  Lines        6911     6912       +1     
  Branches     1919     1918       -1     
==========================================
+ Hits         6735     6736       +1     
  Misses        176      176
Impacted Files Coverage 螖
components/table/Table.tsx 96.66% <100%> (+0.02%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 074fa32...0cb24d8. Read the comment docs.

@zombieJ zombieJ merged commit d96ab1c into master Feb 1, 2020
28 checks passed
@zombieJ zombieJ deleted the table-expand branch Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants