Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Form.Item name 0 processing #21186

Merged
merged 2 commits into from Feb 3, 2020
Merged

Conversation

wanjas
Copy link
Contributor

@wanjas wanjas commented Feb 3, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

#21179

馃挕 Background and solution

Maybe I'm neat picking but I think that fix in #21179 isn't completely correct. It fixes an issue with the Form.List but falsy values aren't handled correctly later in the script, specifically null.

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Feb 3, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Feb 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 47ced40:

Sandbox Source
antd reproduction template Configuration

@afc163 afc163 removed the bug label Feb 3, 2020
@codecov
Copy link

@codecov codecov bot commented Feb 3, 2020

Codecov Report

Merging #21186 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21186      +/-   ##
==========================================
+ Coverage   97.45%   97.45%   +<.01%     
==========================================
  Files         296      296              
  Lines        6913     6918       +5     
  Branches     1918     1920       +2     
==========================================
+ Hits         6737     6742       +5     
  Misses        176      176
Impacted Files Coverage 螖
components/form/FormItem.tsx 99.01% <100%> (+0.05%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 207fc03...47ced40. Read the comment docs.

yoyo837
yoyo837 approved these changes Feb 3, 2020
@afc163 afc163 merged commit 3a72356 into ant-design:master Feb 3, 2020
17 checks passed
@wanjas wanjas deleted the fix-form-item-name branch Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants