Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table.Column should correct handle sorter state #21194

Merged
merged 1 commit into from Feb 3, 2020
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 3, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #21193

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix syntax sugar of Table.Column can not correct handle sorter status.
🇨🇳 Chinese 修复 Table.Column 语法糖不能正确处理排序状态的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Feb 3, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Feb 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3ee32d5:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Feb 3, 2020

Codecov Report

Merging #21194 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21194      +/-   ##
==========================================
+ Coverage   97.45%   97.49%   +0.04%     
==========================================
  Files         296      296              
  Lines        6913     6913              
  Branches     1918     1871      -47     
==========================================
+ Hits         6737     6740       +3     
+ Misses        176      173       -3
Impacted Files Coverage Δ
components/table/util.ts 100% <100%> (ø) ⬆️
components/table/hooks/useSorter.tsx 92.48% <0%> (+2.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 207fc03...3ee32d5. Read the comment docs.

@zombieJ zombieJ merged commit b451940 into master Feb 3, 2020
28 checks passed
@zombieJ zombieJ deleted the fix-table-sugar branch Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants