Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Should TimePicker defaultOpenValue work #21198

Merged
merged 2 commits into from Feb 3, 2020
Merged

fix: Should TimePicker defaultOpenValue work #21198

merged 2 commits into from Feb 3, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 3, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

fix #21153

馃挕 Background and solution

馃 Though we add this prop back, but removed from official doc since this prop is little confused for user understand current value status.

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Fix TimePicker defaultOpenValue not work and remove this from doc since it may confuse user for current value status.
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/time-picker/index.en-US.md
View rendered components/time-picker/index.zh-CN.md

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Feb 3, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Feb 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9200671:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Feb 3, 2020

Codecov Report

Merging #21198 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21198   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         296      296           
  Lines        6918     6918           
  Branches     1873     1873           
=======================================
  Hits         6745     6745           
  Misses        173      173

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3a72356...9200671. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants