Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Form.Item init status should also check help #21211

Merged
merged 2 commits into from Feb 4, 2020
Merged

fix: Form.Item init status should also check help #21211

merged 2 commits into from Feb 4, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 4, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #21206

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Form.Item with help first time hide will make layout jump.
🇨🇳 Chinese 修复 Form.Item 使用 help 第一次去除消息会引发布局抖动的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Feb 4, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Feb 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bfb6e6e:

Sandbox Source
antd reproduction template Configuration
condescending-brattain-8hw18 Issue #21206
loving-breeze-9ttro Issue #21206

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Feb 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 540a295:

Sandbox Source
antd reproduction template Configuration
flamboyant-wind-8igtn Issue #21206
gallant-wave-dm930 Issue #21206

@codecov
Copy link

@codecov codecov bot commented Feb 4, 2020

Codecov Report

Merging #21211 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21211   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         296      296           
  Lines        6918     6918           
  Branches     1920     1921    +1     
=======================================
  Hits         6745     6745           
  Misses        173      173
Impacted Files Coverage Δ
components/form/FormItem.tsx 99.01% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e550921...540a295. Read the comment docs.

@zombieJ zombieJ merged commit ad51283 into master Feb 4, 2020
26 checks passed
@zombieJ zombieJ deleted the fix-form-help branch Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants